fix: prevent duplicate native handler registrations #1085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Added flags to ensure
addEventListener()only registers each native handler once per event type, eliminating unnecessarycordova.execcalls.Details
Motivation
I noticed that we may be creating too many native handlers, once per each invocation of
addEventListener(). This could cause a potential memory leak in the consuming applications.Scope
Any
addEventListenerfunction across theInAppMessages,Notifications,User, andPushSubscriptionnamespaces.Testing
Unit testing
One tested added that ensures that
cordova.execis only called once, no matter how many event listeners are added.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is